Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running sinol-make from package's subdirectory #129

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Allow running sinol-make from package's subdirectory #129

merged 5 commits into from
Sep 24, 2023

Conversation

MasloMaslane
Copy link
Member

No description provided.

@MasloMaslane
Allow running sinol-make in subdirectory of package
2fa690a 
(cherry picked from commit 8151dba)
@MasloMaslane
Add test
63bd382 
(cherry picked from commit 902abc4)
@MasloMaslane MasloMaslane self-assigned this Sep 23, 2023
tonowak
tonowak approved these changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@tonowak tonowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's a bit hacky. Can we make it more clear what the function does from its name?

@MasloMaslane
Merge branch 'main' into running-from-subdirectory
c42ec7c 
# Conflicts:
#	tests/commands/run/test_integration.py
@MasloMaslane
Fix tests
b70861f
@MasloMaslane MasloMaslane merged commit 13351c2 into main Sep 24, 2023
8 checks passed
@MasloMaslane MasloMaslane deleted the running-from-subdirectory branch September 24, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonowak tonowak Awaiting requested review from tonowak

Assignees

@MasloMaslane MasloMaslane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasloMaslane @tonowak